WIP - Updating authenticators from latest in Tiled #81
+365
−173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Wow, thanks @davidpcls! |
Contributor
|
Thank you. I am going to try to fix the unit tests first, I may push a few commits. |
|
If either of you intend to commit more work to this PR, put it in Draft mode. Change the mode back when you are ready for final review. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes bring in the authenticators from Tiled into HTTP Bluesky. This allows us to use the same authentication setup as from Tiled deployements (at least at the current moment). The main other change is to remove the "mode" flag and instead use the class type to determine if it is an internal or external authenticator.
I'm creating this PR to determine if the community is okay with these changes. If so I will put in the effort to update unit tests, etc.
Motivation and Context
This solves the problem of having different authentication schemes to maintain between Tiled and HTTP server, which came from the same code around 3 years ago. Tiled has been updated but HTTP server was not. This addresses that.
Ideally this code would be moved into a common repo that both Tiled and HTTP server can pull from. This PR would enable that if there is desire to do this work, as it puts both Tiled and HTTP server onto the same code base.
Summary of Changes for Release Notes
Updated authenticators based off Tiled main.
Made minimal changes to app.py and authentication.py to support the changes.
Fixed
Added
Authenticators.py from Tiled (fd2a646e4ec73e08fb206f18deaa51c166ccd37a)
Changed
Removed
How Has This Been Tested?
TBD